chore: Enable NuGet trusted publishing #498
Open
+12
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
lahirumaramba
approved these changes
Jan 16, 2026
| run: ./.github/scripts/publish_preflight_check.sh | ||
|
|
||
| # See: https://cli.github.com/manual/gh_release_create | ||
| - name: Create release tag |
Member
There was a problem hiding this comment.
Should we move this after the Publish to Nuget step? Assuming if publishing fails if wouldn't create a release tag?
Collaborator
Author
There was a problem hiding this comment.
I think the reasoning here might have been that if there was an issue with the release, it would be easier to manually revert the tag but if the tag creating fails we can't really revert to resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://learn.microsoft.com/en-us/nuget/nuget-org/trusted-publishing
Also removed unused release tweet action.